adoroszlai commented on code in PR #17:
URL:
https://github.com/apache/ozone-docker-runner/pull/17#discussion_r1183721434
##########
.github/workflows/build.yaml:
##########
@@ -19,9 +19,9 @@ on:
jobs:
build:
name: build and deploy
- runs-on: ubuntu-18.04
+ runs-on: ubuntu-latest
steps:
- name: checkout source
uses: actions/checkout@v2
- name: build image
- run: DOCKER_BUILDKIT=1 docker build -t ghcr.io/$(echo
$GITHUB_REPOSITORY | sed 's/docker-//g') .
+ run: DOCKER_BUILDKIT=1 docker build -t ghcr.io/$(echo
$GITHUB_REPOSITORY | tr '[:upper:]' '[:lower:]' | sed 's/docker-//g') .
Review Comment:
If you intend to fix HDDS-8524 separately, this part of the change should be
removed. I'm OK with including it here and fixing it in the same commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
