smengcl commented on code in PR #4473:
URL: https://github.com/apache/ozone/pull/4473#discussion_r1184515424
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/signature/StringToSignProducer.java:
##########
@@ -288,22 +309,14 @@ static void validateSignedHeader(
String header,
String headerValue
)
- throws OS3Exception {
+ throws OS3Exception, DateTimeParseException {
switch (header) {
case HOST:
- try {
- URI hostUri = new URI(schema + "://" + headerValue);
- InetAddress.getByName(hostUri.getHost());
- // TODO: Validate if current request is coming from same host.
- } catch (UnknownHostException | URISyntaxException e) {
- LOG.error("Host value mentioned in signed header is not valid. " +
- "Host:{}", headerValue);
- throw S3_AUTHINFO_CREATION_ERROR;
- }
+ // TODO: Placeholder for any host validations.
Review Comment:
Agreed. Shall we remove this TODO then? @SaketaChalamchala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
