smengcl commented on code in PR #4519:
URL: https://github.com/apache/ozone/pull/4519#discussion_r1185723563
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -136,7 +136,7 @@ public Response getClusterState() {
}
Long totalKeys = 0L;
- Long deletedKeys = 0L;
+ Long keysAwaitingDeletion = 0L;
Review Comment:
@ArafatKhan2198 On the contrary, I would think `keysAwaitingDeletion` would
make contributors less experienced to Recon code more confusing. They would
definitely notice the inconsistency between UI / the rest of the Ozone code
(like
[below](https://github.com/apache/ozone/blob/cdd96b8bafed44011d4459b65cc6192eaff7d736/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L608))
and this. And generally in my workflow (and maybe many other) when I'm
searching the codebase with a keyword, I would expect
`keypending`/`keyspending` pointing me straight to the relevant code.
https://github.com/apache/ozone/blob/cdd96b8bafed44011d4459b65cc6192eaff7d736/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L608
Indeed, `keyPendingDeletion` is not the most accurate wording. But I would
value code base **consistency** more in this case. We can also add comments
around it.
(To be more accurate, the variable name could be
`deletedKeysPendingBlockReclamation`, but don't use this because it is also
inconsistent with the rest of the code base. Maybe we can do a refactoring
later to change all the names consistently in one PR, or just add more comments
to help others make more sense out of it. :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
