smengcl commented on code in PR #4584:
URL: https://github.com/apache/ozone/pull/4584#discussion_r1185761221
##########
hadoop-hdds/rocks-native/pom.xml:
##########
@@ -436,5 +449,24 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>noNativeTest</id>
Review Comment:
[Conventionally](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#profile-order)
maven profile id uses hyphen with all lower cases:
```suggestion
<id>disable-native-testing</id>
```
##########
hadoop-hdds/rocks-native/src/test/java/org/apache/hadoop/hdds/utils/db/managed/TestManagedSSTDumpIterator.java:
##########
Review Comment:
Apache License header?
##########
hadoop-hdds/rocks-native/src/test/java/org/apache/hadoop/hdds/utils/db/managed/NativeTests.java:
##########
Review Comment:
Apache License header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
