adoroszlai commented on PR #3741:
URL: https://github.com/apache/ozone/pull/3741#issuecomment-1535975597
@neils-dev please trim "extended description" when merging PR. I think
listing all individual commit messages from the PR (which Github does by
default) is unnecessary, and in this case it is really overly verbose:
```
HDDS-6449. Failed container delete can leave artifacts on disk (#3741)
* cleanUpManager - tmpDir - rename container path - delete container in
tmpDir
* TestContainerDeleteWithSchemaV3Enabled improvement, cleanup
* cleanTmpDir on datanode start and shutdown, cleanup
* File.renameTo - rename before deletes if V3 enabled
* datanode service start/stop cleanTmpDir()
* HddsDatanodeService cleanTmpDir() getting schema
* testing cleanTmpDir on datanode start/stop
* modify /tmp path based on volume
* adding cluster id to /tmp path
* remove flag SchemaV3Enabled - clusterId/scmId on the /tmp path
* move cleanTmpDir startup hook to VersionEndpointTask
* no changes
* checking if schema v3 enabled
* check schema v3 is enabled using configuration in CleanUpManager
* initialize CleanUpManager if schemaV3 -
testDeleteContainerWithSchemaV3Enabled execute conditionally
* TestHddsDatanodeService - getTmpDirPath from CleanUpManager
* TestKeyValueHandler testDeleteContainerWithSchemaV3Enabled
* TestContainerPersistence fix
* findbugs errors fixed
* TestEndpoint test clean tmp dir on datanode startup
* TestContainerPersistence fix - datanode startup hook moved
* checkstyle fix
* failing tests fixed
* cleanup
* cleanup - moving CleanUpManager under common.helpers package
* check instance of containerdata - cleanup
* TestContainerPersistence findbugs error fix
* CleanUpManager.renameDir javadoc comment
* CleanUpManager.setTmpDirPath exception message
* CleanUpManager tmpDirPath made final
* moving tmp dir under HddsVolume
* IntegrationTest error fixed
* deleted tmp files
* TestDatanodeUpgradeToScmHA#testImportContainer fix
* cleanup
* unit tests fixed
* checkstyle fixed
* remove container db failure exception
* db failure rethrow exception
* cleanup
* db failure exception
* container delete operations moved under KeyValueContainerUtil
* workflow errors fixed
* rebasing - TestHddsDatanodeService migrating to junit5
* build errors from rebasing, fixed - KeyValueContainerUtil cleanup
* tests cleaned up
* findbugs error fixed
* null pointer exception for tmp dir during datanode startup fixed
* calling ContainerUtils#getContainerFile from cleanTmpDir - tests
updated
* scm exception if container move failed
* rebasing
* createTmpDir if null, while creating delete service dir
* deleteInternal more specific SCE thrown on container rename
* HddsVolume using Paths lib - cleanup
* remove null check before setting tmp dir paths
* cleanup
* logging error on removeContainerFromDB failure
* cleanup
* removing checkTmpDirs() - tests cleanup
* delete test generated directories
* tests cleanup
* test db entries on tmp dir cleanup
* merging errors fixed
* tests cleanup
* reducing test diffs
---------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
