hemantk-12 commented on code in PR #4617:
URL: https://github.com/apache/ozone/pull/4617#discussion_r1186425155
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -786,29 +753,88 @@ private void generateSnapshotDiffReport(final String
jobKey,
}
}
+ @SuppressWarnings("checkstyle:ParameterNumber")
+ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
+ final Table<String, ? extends WithObjectID> fsTable,
+ final Table<String, ? extends WithObjectID> tsTable,
+ final OmSnapshot fromSnapshot,
+ final OmSnapshot toSnapshot,
+ final SnapshotInfo fsInfo,
+ final SnapshotInfo tsInfo,
+ final boolean useFullDiff,
+ final Map<String, String> tablePrefixes,
+ final PersistentMap<byte[], byte[]> oldObjIdToKeyMap,
+ final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
+ final PersistentSet<byte[]> objectIDsToCheck,
+ final String diffDir
+ ) throws IOException, RocksDBException {
+
+ List<String> tablesToLookUp = Collections.singletonList(fsTable.getName());
+
+ Set<String> deltaFiles = getDeltaFiles(fromSnapshot, toSnapshot,
+ tablesToLookUp, fsInfo, tsInfo, useFullDiff, tablePrefixes, diffDir);
+
+ // Workaround to handle deletes if native rocksDb tool for reading
+ // tombstone is not loaded.
+ // TODO: [SNAPSHOT] Update Rocksdb SSTFileIterator to read tombstone
+ if (!sstDumpTool.isPresent()) {
+ deltaFiles.addAll(getSSTFileListForSnapshot(fromSnapshot,
+ tablesToLookUp));
+ }
+
+ try {
+ addToObjectIdMap(fsTable,
+ tsTable,
+ deltaFiles,
+ sstDumpTool.isPresent(),
+ oldObjIdToKeyMap,
+ newObjIdToKeyMap,
+ objectIDsToCheck,
+ tablePrefixes);
+ } catch (NativeLibraryNotLoadedException e) {
+ try {
Review Comment:
Added the log statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
