ashishkumar50 commented on code in PR #4655:
URL: https://github.com/apache/ozone/pull/4655#discussion_r1187259369
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/HddsTestUtils.java:
##########
@@ -736,7 +736,8 @@ public static ContainerReplica.ContainerReplicaBuilder
getReplicaBuilder(
.setDatanodeDetails(datanodeDetails)
.setOriginNodeId(originNodeId).setSequenceId(sequenceId)
.setBytesUsed(usedBytes)
- .setKeyCount(keyCount);
+ .setKeyCount(keyCount)
Review Comment:
This is in server-scm which doesn't use block count. Here existing test case
is just to determine whether replica has some keys or not. If some keys are
present then setEmpty as false.
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationTestUtil.java:
##########
@@ -160,6 +160,7 @@ public static ContainerReplica
createContainerReplica(ContainerID containerID,
builder.setDatanodeDetails(datanodeDetails);
builder.setSequenceId(0);
builder.setOriginNodeId(originNodeId);
+ builder.setEmpty(keyCount == 0);
Review Comment:
This is in server-scm which doesn't use block count. Here existing test case
is just to determine whether replica has some keys or not. If some keys are
present then setEmpty as false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
