tanvipenumudy commented on PR #4663: URL: https://github.com/apache/ozone/pull/4663#issuecomment-1539780467
Thank you @duongkame for the review. - Thank you for bringing up these points - I think it is a valid point that the service logs typically do not generate a significant volume of logs unless there are unexpected issues. - For audit logging in Ozone, I believe it is already set to asynchronous logging by default via the Log4j 2 properties: [om-audit-log4j2.properties](https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/shell/conf/om-audit-log4j2.properties#L92) - similarly for s3g, scm and dn. - Log4j offers the AsyncAppender class, which allows us to perform logging asynchronously. AsyncRFAAppender offers an advantage over the AsyncAppender when it comes to combining asynchronous logging with the rolling file functionality + it provides any additional configuration options if needed. I think we will need to evaluate if going by standard AsyncAppender would suffice and be a simpler implementation when compared to the custom AsyncRFAAppender if we choose to make the service logs asynchronous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
