kerneltime commented on code in PR #4597:
URL: https://github.com/apache/ozone/pull/4597#discussion_r1189130765
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -504,6 +508,44 @@ public static SCMSecurityProtocol getScmSecurityClient(
SCMSecurityProtocol.class, conf);
}
+ public static SCMSecretKeyProtocolClientSideTranslatorPB
Review Comment:
Please add a Java doc explaining that this API is used only if the user is
the DN identity. Same for the API for OM.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecretKeysApi.java:
##########
@@ -155,11 +156,12 @@ private void setSecureConfig() throws IOException {
String realm = miniKdc.getRealm();
String hostAndRealm = host + "@" + realm;
- conf.set(HDDS_SCM_KERBEROS_PRINCIPAL_KEY, "scm/" + hostAndRealm);
+ ozonePrincipal = "scm/" + hostAndRealm;
+ conf.set(HDDS_SCM_KERBEROS_PRINCIPAL_KEY, ozonePrincipal);
conf.set(HDDS_SCM_HTTP_KERBEROS_PRINCIPAL_KEY, "HTTP_SCM/" + hostAndRealm);
- conf.set(OZONE_OM_KERBEROS_PRINCIPAL_KEY, "scm/" + hostAndRealm);
+ conf.set(OZONE_OM_KERBEROS_PRINCIPAL_KEY, ozonePrincipal);
Review Comment:
why use the same principal for SCM, DN and OM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
