krishnaasawa1 commented on code in PR #4682:
URL: https://github.com/apache/ozone/pull/4682#discussion_r1192188597


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -212,6 +216,8 @@ public final class ScmConfigKeys {
       "hdds.rest.http-address";
   public static final String HDDS_REST_HTTP_ADDRESS_DEFAULT = "0.0.0.0:9880";
   public static final String HDDS_DATANODE_DIR_KEY = "hdds.datanode.dir";
+  public static final String HDDS_DATANODE_DIR_PERMISSION =

Review Comment:
   How this is changing default to 700 for DN storage dirs without specifing in 
ozone defaults?



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -683,6 +691,14 @@
       dfs.container.ratis.datanode.storage.dir be configured separately.
     </description>
   </property>
+  <property>
+    <name>ozone.metadata.dirs.permissions</name>
+    <value>777</value>

Review Comment:
   Do default needs to more restrictive 750 or 755 or what's advantage of 
adding this and other properties below with 777 or full permission? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to