devmadhuu commented on code in PR #4540:
URL: https://github.com/apache/ozone/pull/4540#discussion_r1192443733
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/recon/ReconConfigKeys.java:
##########
@@ -36,6 +36,10 @@ private ReconConfigKeys() {
"ozone.recon.datanode.address";
public static final String OZONE_RECON_ADDRESS_KEY =
"ozone.recon.address";
+ public static final String OZONE_SOLR_ADDRESS_KEY =
Review Comment:
> parameter name should be ozone.recon.solr.address to be consistent with
other property
This property "solr.address" is not directly related to recon or provide by
recon config, rather it is populated externally if solr service is available.
So I think it is better not to give any prefix of "recon" in param name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
