smengcl commented on code in PR #4657:
URL: https://github.com/apache/ozone/pull/4657#discussion_r1195800724
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1257,9 +1259,29 @@ private void loadJobsOnStartUp() {
}
@Override
- public void close() throws Exception {
+ public void close() {
+ if (snapDiffExecutor != null) {
+ closeExecutorService(snapDiffExecutor, "SnapDiffExecutor");
+ }
+ if (sstDumpToolExecutor != null) {
+ closeExecutorService(sstDumpToolExecutor, "SstDumpToolExecutor");
+ }
+ }
+
+ private void closeExecutorService(ExecutorService executorService,
+ String serviceName) {
if (executorService != null) {
- executorService.shutdown();
+ LOG.info("Shutting down executorService {}", serviceName);
Review Comment:
```suggestion
LOG.info("Shutting down executorService: {}", serviceName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
