ivandika3 commented on code in PR #4696:
URL: https://github.com/apache/ozone/pull/4696#discussion_r1196626765
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java:
##########
@@ -76,13 +87,12 @@ public ContainerKeyMapperTask(ReconContainerMetadataManager
@Override
public Pair<String, Boolean> reprocess(OMMetadataManager omMetadataManager) {
long omKeyCount = 0;
- // Maps the (container, key) -> count
+
+ // In-memory maps for fast look up and batch write
+ // key -> containerId
Review Comment:
Thank you for the review. Yes, you are correct. Thanks for the catch.
Addressed.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java:
##########
@@ -145,8 +196,17 @@ public Pair<String, Boolean> process(OMUpdateEventBatch
events) {
Iterator<OMDBUpdateEvent> eventIterator = events.getIterator();
int eventCount = 0;
final Collection<String> taskTables = getTaskTables();
+
+ // In-memory maps for fast look up and batch write
+ // (HDDS-8580) containerKeyMap map is allowed to be used
+ // in "process" without batching since the maximum number of keys
+ // is bounded by delta limit configurations
+
+ // key -> containerId
Review Comment:
Addressed. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
