swamirishi commented on code in PR #4721:
URL: https://github.com/apache/ozone/pull/4721#discussion_r1196805823
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -225,6 +224,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
if (exception == null) {
LOG.info("Created snapshot '{}' under path '{}'",
snapshotName, snapshotPath);
+ omMetrics.incNumSnapshotActive();
Review Comment:
Would it not be better to write a unit testcase for this? As far as I
understand this should be still a smaller test & runtime of a unit test would
be faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
