aswinshakil commented on code in PR #4701:
URL: https://github.com/apache/ozone/pull/4701#discussion_r1196941252


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -154,15 +156,29 @@ public BackgroundTaskResult call() {
             subFileNum += request.getDeletedSubFilesCount();
           }
 
-          optimizeDirDeletesAndSubmitRequest(remainNum, dirNum, subDirNum,
-              subFileNum, allSubDirList, purgePathRequestList, null, 
startTime);
+          // Acquire deletedTable write lock this late to allow KeyDeletingTask
+          // to interleave up until this point
+          getOzoneManager().getMetadataManager().getTableLock(

Review Comment:
   Do we need `DELETED_TABLE` lock here? We are not accessing `deletedTable` in 
the `DirectoryDeletingService`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to