ashishkumar50 commented on PR #4655: URL: https://github.com/apache/ozone/pull/4655#issuecomment-1552329317
> Thanks for taking this up @ashishkumar50. I have some comments on the delete flag handling on SCM. Also the following cases need test coverage: > > * isEmpty flag is correctly set on a container when it is imported as part of replication. > * isEmpty flag is correctly set on a container after loading it from memory (restart) > * SCM will only send delete command when isEmpty is true on all replicas, regardless of block count or other metadata. Hi @errose28, Thanks for the review. All review comments are addressed and test cases added. Can you please look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
