adoroszlai opened a new pull request, #4728:
URL: https://github.com/apache/ozone/pull/4728

   ## What changes were proposed in this pull request?
   
   `ECReconstructionCoordinator` should be closed to avoid:
   
   ```
   SEVERE: *~*~*~ Previous channel ManagedChannelImpl{logId=1375, 
target=10.1.1.154:15058} was not shutdown properly!!! ~*~*~*
       Make sure to call shutdown()/shutdownNow() and wait until 
awaitTermination() returns true.
   java.lang.RuntimeException: ManagedChannel allocation site
        ...
        at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.connectToDatanode(XceiverClientGrpc.java:188)
        ...
        at 
org.apache.hadoop.hdds.scm.XceiverClientManager.getClient(XceiverClientManager.java:224)
        at 
org.apache.hadoop.hdds.scm.XceiverClientManager.acquireClient(XceiverClientManager.java:168)
        at 
org.apache.hadoop.hdds.scm.XceiverClientManager.acquireClient(XceiverClientManager.java:141)
        at 
org.apache.hadoop.ozone.container.ec.reconstruction.ECContainerOperationClient.listBlock(ECContainerOperationClient.java:84)
        at 
org.apache.hadoop.ozone.container.ec.reconstruction.ECReconstructionCoordinator.getBlockDataMap(ECReconstructionCoordinator.java:436)
        at 
org.apache.hadoop.ozone.container.ec.reconstruction.ECReconstructionCoordinator.reconstructECContainerGroup(ECReconstructionCoordinator.java:144)
        at 
org.apache.hadoop.hdds.scm.storage.TestContainerCommandsEC.testOrphanBlock(TestContainerCommandsEC.java:371)
   ```
   
   https://issues.apache.org/jira/browse/HDDS-8642
   
   ## How was this patch tested?
   
   Ran test locally few times, verified no warning related to shutdown.  (Test 
may intermittently fail due to HDDS-8476, though.)
   
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/5010672609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to