adoroszlai commented on PR #4584: URL: https://github.com/apache/ozone/pull/4584#issuecomment-1553520314
@prashantpogde please remove unnecessary details from the commit message when merging PRs. "Address review comments", "Fix checkstyle" and similar items from individual commit messages do not add any value, but make git log for everyone unnecessarily long. ``` $ git show beec17828524cb53ccf496e23f9e0cb93b3cf7a0 commit beec17828524cb53ccf496e23f9e0cb93b3cf7a0 (HEAD -> master, origin/master, origin/HEAD) Author: Swaminathan Balachandran <[email protected]> Date: Thu May 18 11:14:57 2023 -0700 HDDS-8306. [Snapshot] Fix SSTDumptool to allow null character & add tests for SST dump tool (#4584) * HDDS-8306. [Snapshot] Add tests for SST dump tool * HDDS-8306. Address review comments * HDDS-8306. Fix Failures * HDDS-8306. Fix checkstyle * HDDS-8306. Address review comments * HDDS-8306. Address review comments * HDDS-8306. Address review comments * HDDS-8306. Address review comments * HDDS-8306. Address review comments * HDDS-8306. Address review comments * HDDS-8306. Fix checkstyle * HDDS-8306. Address review comments * HDDS-8306. Address review comments diff --git hadoop-hdds/rocks-native/pom.xml hadoop-hdds/rocks-native/pom.xml ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
