smengcl commented on code in PR #4571:
URL: https://github.com/apache/ozone/pull/4571#discussion_r1198258323
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java:
##########
@@ -96,42 +95,18 @@ public static void dropColumnFamilyHandle(
public static void checkSnapshotActive(OzoneManager ozoneManager,
String snapshotTableKey)
throws IOException {
- checkSnapshotActive(getSnapshotInfo(ozoneManager, snapshotTableKey));
+ checkSnapshotActive(getSnapshotInfo(ozoneManager, snapshotTableKey),
false);
}
- public static void checkSnapshotActive(SnapshotInfo snapInfo)
+ public static void checkSnapshotActive(SnapshotInfo snapInfo,
+ boolean override)
Review Comment:
Tho it sounds a bit weird to have a param to skip the check for the check
method. If we fix the caller, how many places do we have to change? If not many
we should do that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
