smengcl commented on PR #4680: URL: https://github.com/apache/ozone/pull/4680#issuecomment-1555454097
> @GeorgeJahad @smengcl > > > > > You could leave a TODO in this PR for this, and file a new jira for the compaction entry sequence number addition. (up to you) > > > That would be my preference. I think it is a much better solution than the pausing compactions. Is that ok with you @prashantpogde ? > > It's a better solution but Its much simpler to just pause and resume the background compaction. I would favor simplicity over the other solution because sync up with leader would be an infrequent activity. I would leave it to you to decide on this. Another downside of [`pauseBackgroundWork()`](https://javadoc.io/static/org.rocksdb/rocksdbjni/7.7.3/org/rocksdb/RocksDB.html#pauseBackgroundWork--) is that it [waits](https://github.com/facebook/rocksdb/blob/509116c53b69120133aa9d89eea056bd67634a12/db/db_impl/db_impl_compaction_flush.cc#L1547-L1556) for ALL RocksDB background work to finish before pausing them, not just compaction. That includes any ongoing memtable flush as well, which is unnecessary in our use case here. At this moment I don't see RocksDB implementing API to pause **only** compaction. Thus, IMO `pauseBackgroundWork()` is not ideal and I would only consider it when we don't have other choices (which we do now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
