whbing commented on code in PR #4738:
URL: https://github.com/apache/ozone/pull/4738#discussion_r1199629346
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequestWithFSO.java:
##########
@@ -172,7 +171,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
omPathInfo.getLeafNodeName(),
keyArgs, omPathInfo.getLeafNodeObjectId(),
omPathInfo.getLastKnownParentId(), trxnLogIndex,
- OzoneAclUtil.fromProtobuf(keyArgs.getAclsList()));
+ inheritDefaultAcls(keyArgs, omBucketInfo.getAcls()));
Review Comment:
> If ancestor directory exists, the new directories should inherit from that
ancestor instead of the bucket. I think `omPathInfo` has the information about
the ancestor or bucket in both cases.
@adoroszlai Thanks for suggestion. I have a little doubt. If ancestor
directory exists, will `both DEFAULT and ACCESS ACLs` be inherited, or only the
`DEFAULT acl` will be inherited?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
