[
https://issues.apache.org/jira/browse/HDDS-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724743#comment-17724743
]
Kohei Sugihara commented on HDDS-8637:
--------------------------------------
At the discussion in the GitHub PR, we decided not to add a null check into the
{{KeyValueContainerData#setSchemaVersion}} because it requires changes to
modify checksum computation code only for V1 containers and makes it complex a
bit.
> Add a null check for KeyValueContainerData#setSchemaVersion
> -----------------------------------------------------------
>
> Key: HDDS-8637
> URL: https://issues.apache.org/jira/browse/HDDS-8637
> Project: Apache Ozone
> Issue Type: Improvement
> Components: Ozone Datanode
> Affects Versions: 1.3.0
> Reporter: Kohei Sugihara
> Assignee: Kohei Sugihara
> Priority: Major
>
> Addresses the https://issues.apache.org/jira/browse/HDDS-8636. I've checked
> [the original
> patch|https://github.com/apache/ozone/pull/1298/files#r476042841]
> introducing the setSchemaVersion(), and it has mentioned the default value
> handling into the setter, but it actually unimplemented yet. Adding a null
> check for setSchemaVersion will be a solution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
