smengcl commented on code in PR #4538:
URL: https://github.com/apache/ozone/pull/4538#discussion_r1203211048
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java:
##########
@@ -733,14 +724,14 @@ public void testGetSetRevokeS3Secret() throws Exception {
S3SecretValue attempt3 = omClient.getS3Secret(username);
// secret should differ because it has been revoked previously
- assertNotEquals(attempt3.getAwsSecret(), attempt2.getAwsSecret());
+ assertNotEquals(attempt3.getAwsSecret(), attempt1.getAwsSecret());
// accessKey is still the same because it is derived from username
- assertEquals(attempt3.getAwsAccessKey(), attempt2.getAwsAccessKey());
+ assertEquals(attempt3.getAwsAccessKey(), attempt1.getAwsAccessKey());
// Admin can set secret for any user
- omClient.setS3Secret(username, secretKeySet);
- assertEquals(secretKeySet,
omClient.getS3Secret(username).getAwsSecret());
+ S3SecretValue attempt4 = omClient.setS3Secret(username, secretKeySet);
+ assertEquals(secretKeySet, attempt4.getAwsSecret());
Review Comment:
Add `LambdaTestUtils.intercept()` check after this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
