duongkame commented on code in PR #4760: URL: https://github.com/apache/ozone/pull/4760#discussion_r1203479010
########## hadoop-hdds/framework/pom.xml: ########## @@ -170,6 +170,12 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <groupId>org.awaitility</groupId> <artifactId>awaitility</artifactId> </dependency> + <dependency> Review Comment: Why do we need this change? ########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java: ########## @@ -995,4 +996,6 @@ EchoRPCResponse echoRPCReq(byte[] payloadReq, */ boolean recoverLease(String volumeName, String bucketName, String keyName) throws IOException; + + ManagedSecretKey getCurrentSecretKey() throws IOException; Review Comment: I'm confused about what this API does. Is it supposed to tell OM to fetch the current from SCM? The name and the implementation seems to indicate it only get the current secret key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
