ChenSammi commented on PR #4559: URL: https://github.com/apache/ozone/pull/4559#issuecomment-1560542864
> > Seems to be a breaking change. > > @adoroszlai In fact, in the old version, `read key operation` also required `READ` acl of the link bucket itself. However, in the current patch, we just cannot `addacl/setacl...` on the link bucket itself (will proxy to source). So if an existing link bucket already has the necessary acls, it can be ignored. Right, we grant everyone has RW permission on a link bucket in this patch, without removing any existing permission. So it will be a breaking change. Actually, > > If there is a link bucket in an older version, you need to first authorize the link bucket with world::rw before introducing this patch. > > Seems to be a breaking change. Actually, I think this Hongbin's suggestion is a nice to have action, not a must to have. For any existing old link bucket, it will just not allow anyone to r/w it. But anyone who has the permission to access it, still can do that. Just the new link bucket after this patch can be r/w by everyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
