captainzmc commented on code in PR #4670:
URL: https://github.com/apache/ozone/pull/4670#discussion_r1206338191


##########
hadoop-hdds/docs/content/feature/Reconfigurability.md:
##########
@@ -81,3 +81,41 @@ To: "hadoop,bigdata"
 > $ `ozone admin reconfig -address=hadoop1:9860 properties`<br>
 SCM: Node [hadoop1:9860] Reconfigurable properties:<br>
 ozone.administrators
+
+## Datanode Reconfigurability
+
+**Reconfigurable properties**
+key | description
+-----------------------------------|-----------------------------------------
+
+>For example, modify `ozone.example.config` in ozone-site.xml and execute:
+>
+> $ `ozone admin reconfig --address=hadoop1:9864 start`<br>
+Datanode: Started reconfiguration task on node [hadoop1:9864].
+>
+>$ `ozone admin reconfig --address=hadoop1:9864 status`<br>
+Datanode: Reconfiguring status for node [hadoop1:9864]: started at Wed Dec 28 
19:04:44 CST 2022 and finished at Wed Dec 28 19:04:44 CST 2022.<br>
+SUCCESS: Changed property ozone.example.config<br>
+From: "old"<br>
+To: "new"
+>
+> $ `ozone admin reconfig -address=hadoop1:9864 properties`<br>
+Datanode: Node [hadoop1:9864] Reconfigurable properties:<br>
+ozone.example.config
+
+### Batch operation
+If you want to perform a batch operations on the Datanode, you can set 
`--address` to `inservicenodes`.<br>

Review Comment:
   Do we need to change the documentation here? You first version used 
"--address=inservicenodes", but at present it changed to 
"--in-service-datanodes".
   
   `If you want to perform a batch operations on the Datanode, you can set 
`--in-service-datanodes`.<br>`



##########
hadoop-hdds/docs/content/feature/Reconfigurability.md:
##########
@@ -81,3 +81,41 @@ To: "hadoop,bigdata"
 > $ `ozone admin reconfig -address=hadoop1:9860 properties`<br>
 SCM: Node [hadoop1:9860] Reconfigurable properties:<br>
 ozone.administrators
+
+## Datanode Reconfigurability
+
+**Reconfigurable properties**
+key | description
+-----------------------------------|-----------------------------------------
+
+>For example, modify `ozone.example.config` in ozone-site.xml and execute:
+>
+> $ `ozone admin reconfig --address=hadoop1:9864 start`<br>
+Datanode: Started reconfiguration task on node [hadoop1:9864].
+>
+>$ `ozone admin reconfig --address=hadoop1:9864 status`<br>
+Datanode: Reconfiguring status for node [hadoop1:9864]: started at Wed Dec 28 
19:04:44 CST 2022 and finished at Wed Dec 28 19:04:44 CST 2022.<br>
+SUCCESS: Changed property ozone.example.config<br>
+From: "old"<br>
+To: "new"
+>
+> $ `ozone admin reconfig -address=hadoop1:9864 properties`<br>
+Datanode: Node [hadoop1:9864] Reconfigurable properties:<br>
+ozone.example.config
+
+### Batch operation
+If you want to perform a batch operations on the Datanode, you can set 
`--address` to `inservicenodes`.<br>
+This will send reconfiguration requests to all available DataNodes in the 
`IN_SERVICE`operational state.<br>
+When you perform a batch operation, you must use `-t/--type` to specify the 
type of 
+node to operate on. Currently, only Datanode supports batch operations<br>
+
+
+>For example, to list the reconfigurable properties of all Datanodes:<br>
+> $ `ozone admin reconfig -t datanode --address=inservicenodes properties`<br>

Review Comment:
   --in-service-datanodes
   
   Tips:Another zh.md document also needs to be change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to