Tejaskriya commented on code in PR #4538:
URL: https://github.com/apache/ozone/pull/4538#discussion_r1209787755


##########
hadoop-ozone/dist/src/main/smoketest/s3/commonawslib.robot:
##########
@@ -72,7 +72,9 @@ Setup v4 headers
     Run Keyword if      '${SECURITY_ENABLED}' == 'false'    Setup dummy 
credentials for S3
 
 Setup secure v4 headers
-    ${result} =         Execute                    ozone s3 getsecret 
${OM_HA_PARAM}
+    ${result} =         Execute and Ignore error             ozone s3 
getsecret ${OM_HA_PARAM}

Review Comment:
   Without `and ignore error` , the test fails immediately at the Execute line 
if the following command returns an error response. In order to be able to 
check the output returned, I have added `Execute and Ignore Error`. In the next 
line the output is verified. If it's an unexpected output then we are alarmed 
about the problem in the next line using the `should contain`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to