adoroszlai opened a new pull request, #4794: URL: https://github.com/apache/ozone/pull/4794
## What changes were proposed in this pull request? Some logic related to reconfiguration can be refactored into a common handler object to reduce the complexity and avoid duplication. https://issues.apache.org/jira/browse/HDDS-8702 ## How was this patch tested? Added unit test, refactored existing integration test. Tested CLI commands in `ozone` compose environment. ``` $ docker-compose exec om bash bash-4.2$ ozone admin reconfig --address om:9862 properties OM: Node [om:9862] Reconfigurable properties: ozone.administrators ozone.readonly.administrators bash-4.2$ vi /etc/hadoop/ozone-site.xml bash-4.2$ ozone admin reconfig --address om:9862 start OM: Started reconfiguration task on node [om:9862]. bash-4.2$ ozone admin reconfig --address om:9862 status OM: Reconfiguring status for node [om:9862]: started at Thu May 25 15:26:05 UTC 2023 and finished at Thu May 25 15:26:05 UTC 2023. SUCCESS: Changed property ozone.administrators From: "" To: "foo" bash-4.2$ exit $ docker-compose exec scm bash bash-4.2$ ozone admin reconfig --address scm:9860 properties SCM: Node [scm:9860] Reconfigurable properties: ozone.administrators bash-4.2$ vi /etc/hadoop/ozone-site.xml bash-4.2$ ozone admin reconfig --address scm:9860 start SCM: Started reconfiguration task on node [scm:9860]. bash-4.2$ ozone admin reconfig --address scm:9860 status SCM: Reconfiguring status for node [scm:9860]: started at Thu May 25 15:33:59 UTC 2023 and finished at Thu May 25 15:33:59 UTC 2023. SUCCESS: Changed property ozone.administrators From: "" To: "bar" bash-4.2$ exit ``` https://github.com/adoroszlai/hadoop-ozone/actions/runs/5117942592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
