szetszwo commented on PR #3082:
URL: https://github.com/apache/ozone/pull/3082#issuecomment-1568574140

   > ...  for the readability.
   
   If the code are the same, it is better to reuse the code.
   
   ```java
   //SCMMetadataStoreImpl
     private Table<BigInteger, X509Certificate> validCertsTable;
     private Table<BigInteger, X509Certificate> validSCMCertsTable;
     private Table<BigInteger, X509Certificate> revokedCertsTable;
   ```
   For examples, we won't create a different `BigInteger` and a different 
`X509Certificate` for the tables above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to