fapifta commented on PR #4807: URL: https://github.com/apache/ozone/pull/4807#issuecomment-1571448102
@adoroszlai I agree, @Galsza I would like to propose a method on the CertificateSignRequest.Builder, and in parallel on the SeflSignedCertificate.Builder, something like addInetAddresses(List<InetAddress> addresses, DomainValidator validator) so that we can write tests for the method, and call it from the places where we have this code piece written. Mostly these are test classes but in any ways I think it is better to encapsulate this logic within those builders. Let me know if you have a better idea ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
