devmadhuu commented on code in PR #4822: URL: https://github.com/apache/ozone/pull/4822#discussion_r1217508209
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/Feature.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.api.types; + +import java.util.Arrays; +import java.util.List; +import java.util.stream.Collectors; + +/** + * The Feature list of Recon. This list may grow in the future. + * If this list grows bigger, then this may be loaded from Sql DB. + */ +public enum Feature { + HEATMAP("HeatMap", false) { + private boolean disabled; Review Comment: @sumitagrawl Thanks for review, If more features will be added in this enum, then based on different criteria, this is overridden as of now. So I feel we should see from extensibility point of view and ease of use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
