xichen01 commented on PR #4821: URL: https://github.com/apache/ozone/pull/4821#issuecomment-1577235285
> Thanks @xichen01 for working on this. There are two subtle issues with the patch: > > 1. `checkFullDelete` is skipped when this method is being called from `deleteChunks` (`verifyLength=false`). In that case `Block file to be deleted does not exist` is not logged. Furthermore, this seems to be the common case (`KeyValueHandler.deleteBlock`). > 2. As you mention in the description: > > > For non-existent files ... it prints a log of successful deletions > > I'm afraid performance improvement is possible only due to (1). Thanks for you response. So it is possible that the "`Block` does not exist on the DN", which is a more common case. But from the "flame diagram" of our business, checking for the existence of files consumes a lot of time (our keys are small), and the LOG consumes a lot of time too (Print log to indicate that the deletion may not have been skipped due to non-existent Block)   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
