hemantk-12 commented on code in PR #4695:
URL: https://github.com/apache/ozone/pull/4695#discussion_r1199472242
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -216,6 +219,68 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response) {
}
}
+ /**
+ * Parses request form data parameters.
+ * @param request the HTTP servlet request
+ * @return array of parsed sst form data parameters for exclusion
+ */
+ private static String[] parseFormDataParameters(HttpServletRequest request) {
+ String fieldName = OZONE_DB_CHECKPOINT_REQUEST_TO_EXCLUDE_SST + "[]";
+ ServletFileUpload upload = new ServletFileUpload();
+ List<String> sstParam = new ArrayList<>();
+
+ try {
+ FileItemIterator iter = upload.getItemIterator(request);
+ while (iter.hasNext()) {
+ FileItemStream item = iter.next();
+ if (!item.isFormField()) {
+ continue;
+ }
+
+ if (!item.getFieldName().equals(fieldName)) {
Review Comment:
nit: if conditions can be combined to one.
```suggestion
if (!fieldName.equals(item.getFieldName())
```
to avoid NPE because we know fieldName is constant.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -216,6 +219,68 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response) {
}
}
+ /**
+ * Parses request form data parameters.
+ * @param request the HTTP servlet request
+ * @return array of parsed sst form data parameters for exclusion
+ */
+ private static String[] parseFormDataParameters(HttpServletRequest request) {
+ String fieldName = OZONE_DB_CHECKPOINT_REQUEST_TO_EXCLUDE_SST + "[]";
Review Comment:
This can be a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
