errose28 opened a new pull request, #4838:
URL: https://github.com/apache/ozone/pull/4838
Leaving as draft since there is still some pending test work
## What changes were proposed in this pull request?
Most of the diff is renames and moving methods to different classes.
- Move volume level tmp directory management to `StorageVolume`.
- Volume types other than HddsVolume may need to use the tmp directory.
For example, syncing volume health check files, which will come after this PR.
- Move deleted container directory management to `HddsVolume`.
- This uses the tmp directory from the `StorageVolume` parent class for
container deletion, which is specific to HddsVolumes.
- Rename methods to better reflect tmp directory and deleted container
directory distinction.
- Rename on disk directory from `container_delete_service` to
`deleted-containers` to better reflect its contents.
- There have been no releases with HDDS-6449, so changing this directory
name will not affect released clusters.
- Any clusters built off master between HDDS-6449 and now will ignore the
old directory after this change. It could be manually deleted if desired.
## What is the link to the Apache JIRA
HDDS-8771
## How was this patch tested?
WIP
- [x] Existing tests updated
- [ ] Test for clearing deleted containers on startup that is not in the
server-scm module. `TestEndPoint#testTmpDirCleanup` test case was removed for
this reason but it still needs a replacement in container-service.
- [ ] Manual testing with docker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
