adoroszlai opened a new pull request, #4840:
URL: https://github.com/apache/ozone/pull/4840

   ## What changes were proposed in this pull request?
   
   Show stack trace of `CodecBuffer` allocation for leaked instances if log 
level is at least `DEBUG` (and set such log level for integration tests).
   
   https://issues.apache.org/jira/browse/HDDS-8740
   
   ## How was this patch tested?
   
   Introduced leak by randomly returning from `release()` without actually 
releasing the buffer.  Ran `TestOmMetrics`.  Verified log:
   
   ```
   [Finalizer] WARN  db.CodecBuffer (CodecBuffer.java:finalize(129)) - LEAK 1: 
org.apache.hadoop.hdds.utils.db.CodecBuffer@26701f00, refCnt=1, capacity=24 
allocation:
   org.apache.hadoop.hdds.utils.db.CodecBuffer.allocate(CodecBuffer.java:74)
   
org.apache.hadoop.hdds.utils.db.CodecBuffer.allocateDirect(CodecBuffer.java:82)
   
org.apache.hadoop.hdds.utils.db.StringCodecBase.toCodecBuffer(StringCodecBase.java:175)
   
org.apache.hadoop.hdds.utils.db.StringCodec.toCodecBuffer(StringCodec.java:28)
   
org.apache.hadoop.hdds.utils.db.StringCodecBase.toCodecBuffer(StringCodecBase.java:43)
   org.apache.hadoop.hdds.utils.db.Codec.toDirectCodecBuffer(Codec.java:75)
   org.apache.hadoop.hdds.utils.db.TypedTable.getFromTable(TypedTable.java:358)
   org.apache.hadoop.hdds.utils.db.TypedTable.getFromTable(TypedTable.java:337)
   org.apache.hadoop.hdds.utils.db.TypedTable.get(TypedTable.java:230)
   
org.apache.hadoop.hdds.scm.ha.SequenceIdGenerator.upgradeToSequenceId(SequenceIdGenerator.java:353)
   
org.apache.hadoop.hdds.scm.server.StorageContainerManager.initializeSystemManagers(StorageContainerManager.java:654)
   
org.apache.hadoop.hdds.scm.server.StorageContainerManager.<init>(StorageContainerManager.java:389)
   
org.apache.hadoop.hdds.scm.server.StorageContainerManager.createSCM(StorageContainerManager.java:572)
   org.apache.hadoop.hdds.scm.HddsTestUtils.getScmSimple(HddsTestUtils.java:598)
   
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.createSCM(MiniOzoneClusterImpl.java:735)
   
org.apache.hadoop.ozone.MiniOzoneClusterImpl$Builder.build(MiniOzoneClusterImpl.java:587)
   org.apache.hadoop.ozone.om.TestOmMetrics.startCluster(TestOmMetrics.java:109)
   
org.apache.hadoop.ozone.om.TestOmMetrics.testBucketOps(TestOmMetrics.java:201)
   ```
   
   Temporarily removed setting of log level, verified log has no stack trace:
   
   ```
   [Finalizer] WARN  db.CodecBuffer (CodecBuffer.java:finalize(129)) - LEAK 1: 
org.apache.hadoop.hdds.utils.db.CodecBuffer@26701f00, refCnt=1, capacity=51
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to