xBis7 commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1221265142
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1010,6 +1066,11 @@ private long generateDiffReport(
try (ClosableIterator<byte[]>
objectIdsIterator = objectIDsToCheck.iterator()) {
while (objectIdsIterator.hasNext()) {
+ if (snapDiffJobTable.get(jobKey).getStatus()
Review Comment:
> To avoid NPE.
Yes, the job might have failed or being rejected and got removed from the
table.
> Should we check after like every 100 entries?
Sure, I'll fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
