adoroszlai commented on code in PR #4841:
URL: https://github.com/apache/ozone/pull/4841#discussion_r1221436847
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnhealthyReplicationProcessor.java:
##########
@@ -117,19 +114,27 @@ public void processAll(ReplicationQueue queue) {
healthStateCntMap.compute(healthResult.getHealthState(),
(healthState, cnt) -> cnt == null ? 1 : (cnt + 1));
} catch (Exception e) {
- LOG.error("Error processing Health result of class: {} for " +
- "container {}", healthResult.getClass(),
- healthResult.getContainerInfo(), e);
- failed++;
+ if (e instanceof CommandTargetOverloadedException) {
+ LOG.debug("All targets overloaded when processing Health result of "
+
+ "class: {} for container {}", healthResult.getClass(),
+ healthResult.getContainerInfo(), e);
Review Comment:
Do we want to log stack trace for each such message?
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnhealthyReplicationProcessor.java:
##########
@@ -117,19 +114,27 @@ public void processAll(ReplicationQueue queue) {
healthStateCntMap.compute(healthResult.getHealthState(),
(healthState, cnt) -> cnt == null ? 1 : (cnt + 1));
} catch (Exception e) {
- LOG.error("Error processing Health result of class: {} for " +
- "container {}", healthResult.getClass(),
- healthResult.getContainerInfo(), e);
- failed++;
+ if (e instanceof CommandTargetOverloadedException) {
Review Comment:
Nit: I'd prefer separate `catch` blocks, even if `failedOnes.add` needs to
be duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
