sumitagrawl commented on PR #4811: URL: https://github.com/apache/ozone/pull/4811#issuecomment-1581886647
@aswinshakil Thanks for the info, overwrite case can have same objectId but different version of content. IMO, - Need to have unique key for file key in deletedTable (similar to uncommited block handling in commit request), this will ensure no block leak due to overwrite of key when conflict. - keyDeletingService need compare objectId (as existing) and one of blockId if matching - SnapshotDeletingService also need have similar comparison with additional blockID if matching - Snapdiff also need have similar comparison for identify if object is same or different I think, we can have a change in KeyInfo have have additional field - version, which can be auto-incremented in case of overwrite to distinguish different object and also for debugging identifying overwrite. This can be used to replace blockId compare. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
