xBis7 commented on code in PR #4824: URL: https://github.com/apache/ozone/pull/4824#discussion_r1223119356
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotDiffJob.java: ########## @@ -15,14 +15,15 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.hadoop.ozone.om.snapshot; +package org.apache.hadoop.ozone.om.helpers; Review Comment: I wanted to make the class available to the client and keep diffs to a minimum. We will have to modify around 100 files to make this change. But yes if we rename it we will be more consistent with the rest of the package classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
