devmadhuu commented on code in PR #4626:
URL: https://github.com/apache/ozone/pull/4626#discussion_r1223241805
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OrphanMetaDataManagementTask.java:
##########
@@ -187,4 +262,36 @@ public Pair<String, Boolean> reprocess(OMMetadataManager
omMetadataManager) {
return new ImmutablePair<>(getTaskName(), true);
}
+ private List<OmKeyInfo> getPendingDeletionSubFiles(
+ long volumeId, long bucketId, OmKeyInfo parentInfo)
+ throws IOException {
+ List<OmKeyInfo> files = new ArrayList<>();
+ String seekFileInDB =
+ reconOMMetadataManager.getOzonePathKey(volumeId, bucketId,
+ parentInfo.getObjectID(), "");
+
+ Table fileTable = reconOMMetadataManager.getFileTable();
+ try (TableIterator<String, ? extends Table.KeyValue<String, OmKeyInfo>>
+ iterator = fileTable.iterator()) {
+
+ iterator.seek(seekFileInDB);
+
+ while (iterator.hasNext()) {
+ Table.KeyValue<String, OmKeyInfo> entry = iterator.next();
+ OmKeyInfo fileInfo = entry.getValue();
+ if (!OMFileRequest.isImmediateChild(fileInfo.getParentObjectID(),
+ parentInfo.getObjectID())) {
+ break;
+ }
+ fileInfo.setFileName(fileInfo.getKeyName());
+ String fullKeyPath = OMFileRequest.getAbsolutePath(
+ parentInfo.getKeyName(), fileInfo.getKeyName());
+ fileInfo.setKeyName(fullKeyPath);
+
+ files.add(fileInfo);
Review Comment:
Done the changes.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OrphanMetaDataManagementTask.java:
##########
@@ -171,9 +215,40 @@ private void removeOrphanAndNSSummaryParentEntry(long
objectID) {
}
}
- private void handlePutDeleteDirEvent(OmKeyInfo updatedKeyInfo) {
+ private void addToOrphanMetaData(OmKeyInfo updatedKeyInfo,
+ NSSummary nsSummary) {
long objectID = updatedKeyInfo.getObjectID();
- removeOrphanAndNSSummaryParentEntry(objectID);
+ long parentObjectID = updatedKeyInfo.getParentObjectID();
+ String delDirName = updatedKeyInfo.getKeyName();
+ try {
+ OrphanKeyMetaData orphanKeyMetaData =
+ reconNamespaceSummaryManager.getOrphanKeyMetaData(parentObjectID);
+ if (null != orphanKeyMetaData) {
+ Set<Long> objectIds = orphanKeyMetaData.getObjectIds();
+ objectIds.remove(objectID);
Review Comment:
updating to DB now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
