swamirishi commented on code in PR #4678:
URL: https://github.com/apache/ozone/pull/4678#discussion_r1223364688
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -481,7 +479,7 @@ private SnapshotDiffReportOzone createPageResponse(
private void checkReportsIntegrity(final SnapshotDiffJob diffJob,
final int totalDiffEntries)
throws IOException {
- if (diffJob.getTotalDiffEntries() != totalDiffEntries) {
+ if (diffJob.getTotalDiffEntries() > totalDiffEntries) {
Review Comment:
The check is a good to have if some other function calls this function. We
should check this thing it could so happen that the particular entry could
exist for some reason in the db. In this case we should ideally mark the report
as corrupted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
