hemantk-12 commented on code in PR #4824:
URL: https://github.com/apache/ozone/pull/4824#discussion_r1222242432
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -681,6 +686,14 @@ public SnapshotDiffResponse getSnapshotDiffReport(final
String volume,
return snapshotDiffReport;
}
+ public List<SnapshotDiffJob> getSnapshotDiffList(final String volumeName,
+ final String bucketName,
+ final String jobStatus,
+ final boolean listAll) {
+ return snapshotDiffManager.getSnapshotDiffJobList(
Review Comment:
I think we should validate that `volumeName` and `bucketName` exist to fail
fast? May also add snapshot existed check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
