hemantk-12 commented on PR #4678: URL: https://github.com/apache/ozone/pull/4678#issuecomment-1583359342
Overall PR looks good to me. The cosmetic changes and [this issue](https://github.com/apache/ozone/pull/4678#discussion_r1223551087) can be fixed as separate jira. Please create jira for [this](https://github.com/apache/ozone/pull/4678#discussion_r1223551087). Please fix the checkstyle and other comment I gave. On a side note, please resolve the comments if you have fixed or reply to them with justification. Don't just resolve comments without addressing them in one of the above way. For e.g. 1. https://github.com/apache/ozone/pull/4678/files#r1204811251 1. https://github.com/apache/ozone/pull/4678/files#r1204812669 1. https://github.com/apache/ozone/pull/4678/files#r1204817089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
