GeorgeJahad commented on PR #4567: URL: https://github.com/apache/ozone/pull/4567#issuecomment-1584968462
I see you already implemented your approach and I think it is fine. I just wanted to show you what I meant: Create an interface like this: https://github.com/GeorgeJahad/ozone/compare/siyaosOriginal..addEvictable#diff-dcbfe3b8f20b10894bacf32579a63703629eaf1d38543c696ca786efdbe4cbe3R1-R7 use it like this: https://github.com/GeorgeJahad/ozone/compare/siyaosOriginal..addEvictable#diff-c624eeb3f5cb3e828f7218adb6cc7aca1f0108ff1a30c8a2a456f2d0b027880bR120-R122 and implement it like this: https://github.com/GeorgeJahad/ozone/compare/siyaosOriginal..addEvictable#diff-d5b0b24274c5d19e876dc2ffeb744d4965fa1a23ce727ac09b965f665573c18aR328-R344 The rest of the necessary changes here: https://github.com/GeorgeJahad/ozone/compare/siyaosOriginal..addEvictable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
