adoroszlai commented on code in PR #4874:
URL: https://github.com/apache/ozone/pull/4874#discussion_r1226202243
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnderReplicatedProcessor.java:
##########
@@ -27,9 +29,9 @@
public class UnderReplicatedProcessor extends UnhealthyReplicationProcessor
<ContainerHealthResult.UnderReplicatedHealthResult> {
- public UnderReplicatedProcessor(ReplicationManager replicationManager,
- long intervalInMillis) {
- super(replicationManager, intervalInMillis);
+ UnderReplicatedProcessor(ReplicationManager replicationManager,
+ Supplier<Duration> interval) {
Review Comment:
If we simply pass the current value (`long` or `Duration`), an updated
config value will not be reflected in the `(Under|Over)ReplicatedProcessor`.
Alternatively, we could define an `abstract` method for the interval in
`UnhealthyReplicationProcessor`, and override it in the subclasses, returning
the current value of `ReplicationManager`'s `(under|over)ReplicatedInterval`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
