adoroszlai opened a new pull request, #4877: URL: https://github.com/apache/ozone/pull/4877
## What changes were proposed in this pull request? Coverage is collected by Java agent defined in `OZONE_OPTS`: https://github.com/apache/ozone/blob/b4ea2fb100e7edd7246dc2645dc8723746a68907/hadoop-ozone/dist/src/main/compose/test-all.sh#L35 The problem is that `share/coverage/jacoco-agent.jar` is only available when built from source (i.e. `new_client`), but is not part of the official release, thus also not present in the `apache/ozone` images. ``` xcompat-cluster-1.4.0-client-1.3.0-write :: Write Compatibility ============================================================================== Key Can Be Written | FAIL | 1 != 0 ------------------------------------------------------------------------------ Dir Can Be Created | FAIL | 1 != 0 ------------------------------------------------------------------------------ File Can Be Put | FAIL | 1 != 0 ------------------------------------------------------------------------------ xcompat-cluster-1.4.0-client-1.3.0-write :: Write Compatibility | FAIL | 3 tests, 0 passed, 3 failed ``` caused by: ``` Error opening zip file or JAR manifest missing : share/coverage/jacoco-agent.jar Error occurred during initialization of VM agent library failed to init: instrument ``` This PR removes the docker-compose definition that propagates `OZONE_OPTS` to 1.3.0 client. The problem does not affect 1.2.1 and earlier clients, because only `HADOOP_OPTS` was passed to them. For consistency, `HADOOP_OPTS` is also removed for these, though. In the future we may improve this by using the jar mounted from "current" version. https://issues.apache.org/jira/browse/HDDS-8820 ## How was this patch tested? ``` mvn -Pcoverage -DskipTests clean package export OZONE_TEST_SELECTOR=xcompat export OZONE_WITH_COVERAGE=true ./hadoop-ozone/dev-support/checks/acceptance.sh ``` ``` xcompat-cluster-1.4.0-client-1.3.0-write :: Write Compatibility ============================================================================== Key Can Be Written | PASS | ------------------------------------------------------------------------------ Dir Can Be Created | PASS | ------------------------------------------------------------------------------ File Can Be Put | PASS | ------------------------------------------------------------------------------ xcompat-cluster-1.4.0-client-1.3.0-write :: Write Compatibility | PASS | 3 tests, 3 passed, 0 failed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
