errose28 commented on PR #4655: URL: https://github.com/apache/ozone/pull/4655#issuecomment-1590191032
> I also wonder if the default state for a containerData object should be "empty" and then it gets toggled to "non empty" on the first successful put block to it - that may be one way to catch this scenario, This would complicate SCM code. Instead of sending delete commands to containers with the empty flag set, SCM would have to figure out if the container is empty because it needs to be deleted, or empty because it has not accepted any writes yet. I guess the allocated state could be used to make this distinction, but it would add another complication on the delete path. It also does not resolve your other point below. > it is possible for a container to have an orphan block like this, and other blocks. The other blocks could get removed over time, leaving the container empty except for this. orphan block. As I mentioned above, I think changing the default value of the config to check the directory on container delete is the best solution here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
