swamirishi commented on code in PR #4823:
URL: https://github.com/apache/ozone/pull/4823#discussion_r1230108118
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1033,26 +1075,31 @@ private long generateDiffReport(
throw new IllegalStateException(
"Old and new key name both are null");
} else if (oldKeyName == null) { // Key Created.
- String key = codecRegistry.asObject(newKeyName, String.class);
+ String key = resolveAbsolutePath(isFSOBucket, newParentIdPathMap,
Review Comment:
For FSO it would be parentId/KeyName. for non fso it would be the complete
path. So it would considered as a rename operation. If you look into the
addToObjectIdMap I have changed the key to map, it is not just the keyname
anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
