hemantk-12 commented on code in PR #4824:
URL: https://github.com/apache/ozone/pull/4824#discussion_r1231339487
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -789,6 +794,18 @@ message SnapshotInfo {
optional int64 dbTxSequenceNumber = 12;
}
+message SnapshotDiffJobProto {
+ optional uint64 creationTime = 1;
+ optional string jobId = 2;
Review Comment:
It is OK to return all the parameters here but we should have a client side
`SnapshotDiffJob` similar to
[OzoneKey](https://github.com/apache/ozone/blob/9c6cd4b93e0427fc12bbedae8156c746cbe6cea1/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKey.java#L34)
and
[OzoneSnapshot](https://github.com/apache/ozone/blob/9c6cd4b93e0427fc12bbedae8156c746cbe6cea1/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneSnapshot.java#L27).
And shows only information client parameters and hides the internal parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
