[
https://issues.apache.org/jira/browse/HDDS-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-8854:
-----------------------------------
Description:
{code:java}
{code}
[https://github.com/apache/ozone/blob/0b6a16abbb61049406c3a8b1cdbb5fe06c74bceb/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java#L375-L377]
{code:java}
public DatanodeInfo getNode(DatanodeDetails datanodeDetails)
throws NodeNotFoundException {
return nodeStateMap.getNodeInfo(datanodeDetails.getUuid());
{code}
Some callers create {{DatanodeDetails}} just for the lookup. These could be
avoided by an overloaded method accepting {{UUID}} directly.
was:
{code:title=https://github.com/apache/ozone/blob/0b6a16abbb61049406c3a8b1cdbb5fe06c74bceb/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java#L375-L377}
public DatanodeInfo getNode(DatanodeDetails datanodeDetails)
throws NodeNotFoundException {
return nodeStateMap.getNodeInfo(datanodeDetails.getUuid());
{code}
Several callers create {{DatanodeDetails}} just for the lookup. These could be
avoided by an overloaded method accepting {{UUID}} directly.
Same for {{getNodeStatus}}.
> Avoid unnecessary DatanodeDetails creation for NodeStateManager lookup
> ----------------------------------------------------------------------
>
> Key: HDDS-8854
> URL: https://issues.apache.org/jira/browse/HDDS-8854
> Project: Apache Ozone
> Issue Type: Improvement
> Components: SCM
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
>
> {code:java}
> {code}
> [https://github.com/apache/ozone/blob/0b6a16abbb61049406c3a8b1cdbb5fe06c74bceb/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java#L375-L377]
> {code:java}
> public DatanodeInfo getNode(DatanodeDetails datanodeDetails)
> throws NodeNotFoundException {
> return nodeStateMap.getNodeInfo(datanodeDetails.getUuid());
> {code}
> Some callers create {{DatanodeDetails}} just for the lookup. These could be
> avoided by an overloaded method accepting {{UUID}} directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
